-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Warning that Actor Reminder Partition is not relevant by default #4561
Open
JoshVanL
wants to merge
7
commits into
dapr:v1.15
Choose a base branch
from
JoshVanL:building-blocks-actor-reminder-partition-warning15
base: v1.15
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Adds Warning that Actor Reminder Partition is not relevant by default #4561
JoshVanL
wants to merge
7
commits into
dapr:v1.15
from
JoshVanL:building-blocks-actor-reminder-partition-warning15
+12
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the Actor Reminder Partition config page with a Warning that the feature is only relevant when using state store Actor Reminders which are no longer used by default. De-references this page from the actor rutime config page to softly hide it. Updates some verbiage around using Scheduler reminders & the feature gate as it's on by default. This should be merged in dapr/[email protected]. Signed-off-by: joshvanl <[email protected]>
passuied
approved these changes
Feb 28, 2025
yaron2
approved these changes
Feb 28, 2025
msfussell
reviewed
Mar 7, 2025
daprdocs/content/en/developing-applications/building-blocks/actors/howto-actors-partitioning.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/building-blocks/actors/howto-actors-partitioning.md
Outdated
Show resolved
Hide resolved
@@ -8,6 +8,13 @@ aliases: | |||
- "/developing-applications/building-blocks/actors/actors-background" | |||
--- | |||
|
|||
{{% alert title="Warning" color="warning" %}} | |||
This feature is only relevant when using State Store Actor reminders, no longer enabled by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
This feature is only relevant when using State Store Actor reminders, no longer enabled by default. | |
This feature is only relevant when using state store actor reminders, no longer enabled by default. |
@JoshVanL - This should go into dapr/[email protected] yes? |
Stale PR, paging all reviewers |
@msfussell yes, this is the right place for it |
…tors/howto-actors-partitioning.md Signed-off-by: Mark Fussell <[email protected]>
…tors/howto-actors-partitioning.md Signed-off-by: Mark Fussell <[email protected]>
Stale PR, paging all reviewers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Actor Reminder Partition config page with a Warning that the feature is only relevant when using state store Actor Reminders which are no longer used by default. De-references this page from the actor rutime config page to softly hide it. Updates some verbiage around using Scheduler reminders & the feature gate as it's on by default.
This should be merged in dapr/[email protected].